Design comparison
Solution retrospective
Hey! Did this challenge to practice more on Sass. I had a hard time positioning the background with this one. I didn't know how to make the background positioning responsive with respect to the viewport width, so I ended up using media queries on two specific breakpoints to position it the way I wanted.
Feedback on any part of my code is welcome!
Community feedback
- @MojtabaMosaviPosted over 3 years ago
Hi!, looks good. In a bunch of places you are using fixed heights/widths, while using them gives more controll on the layout, in general using them tends to be the avoided mainly because you've to redefine them on every media querty and thus creating more work for you, Remember we want to be write dry code :). For your breakpoint use em because it has better browser support and it's more responsive.
Keep coding :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord