Skip to content
Submitted almost 4 years ago

Profile card component

LetsFrontend•500
@B1N4R1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first challenge on this webpage, which I think is supercool btw, so let me know what u guys & girls think about my solution. Is there anything to improve? Would u have taken another approach different to mine?

Community feedback

  • ApplePieGiraffe•30,545
    @ApplePieGiraffePosted almost 4 years ago

    Hey, B1N4R1! 👋

    Congratulations upon completing your first challenge on Frontend Mentor! 🎉

    Good job on this one, too! Your solution looks good! 👏

    You've done a good job in positioning the background SVGs in this challenge, but I suggest using CSS background images to add and position the background SVGs in this project. That'll make your HTML cleaner and keep the background SVGs from getting in the way of the other elements on your page. Here's an article to get you started.

    Also, using fewer divs and spans and more semantic HTML tags (like headings and paragraphs) will be a good idea to improve the meaning of your markup. 😉

    Keep coding (and happy coding, too)! 😁

    1
    LetsFrontend•500
    @B1N4R1Posted almost 4 years ago

    @ApplePieGiraffe Thanks for your feedback, I'll definitely lookup CSS background images and try using less divs, spans...

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord