profile card component with flexbox

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @dusvimarin 👋🏻

  Since you are waiting for comments, I think I have one 😅

  • I suggest, instead of giving margin-top to the .container, give min-height: 100vh; to body and it will center the card automatically.

  I hope this was helpful 👨🏻‍💻 great progress on the project, loved it, keep it up. Cheers 👾

  Marked as helpful

  0

  ---

  

  Dusvy_M•390

  @dovelmPosted about 3 years ago

  @kens-visuals thanks!! I learning more of you!!!

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @dusvimarin you're welcome, I'm glad I could be helpful 😇

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. Layout in general looks great.

  kens_visuals already gave great tip on this one, just going to add some suggestions as well:

  • It would be great to have a base styling with these properties

  html {
    box-sizing: border-box;
    font-size: 100%;
  }
  *,
  *::before,
  *::after {
    box-sizing: inherit;
  }
  

  This way, handling an element's size will be lot easier because of the box-sizing: border-box. You can search up some more of how this works.

  • Those small-circles-images on the card, if you set a aria-hidden="true" to an img remember to use empty value for alt like alt="', since you are hiding the element, you should remove all description to the img itself.
  • Person's img should be using the person's name as the alt like alt="VIctor Crest", lose the word profile.
  • Your .footer could have used ul since those are "list" of information about the person's profile.

  Aside from those, site looks great.

  0

  ---

  

  Dusvy_M•390

  @dovelmPosted about 3 years ago

  @pikamart thanks!!! I'm learning much

  1