Profile Card Component with clean HTML and CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 3 years ago

  Hello

  Looks great on my phone except some of the text is unreadably small. 0.6 rem is TINY.

  Html could really be improved on this. Small changes but all very important

  • look up how to write alt text on images
  • read about landmarks and why they matter. Applying them will fix the automated accessibility errors on this
  • rethink the stats section at the bottom. I guarantee there are more appropriate semantically meaningful elements you could use instead of a paragraph for every word.

  Good luck

  Marked as helpful

  0

  ---

  

  Mohsin Miyaji•440

  @mohsin316Posted about 3 years ago

  @grace-snow Hey grace! Ive updated the font size from .6 rem to .85rem. Hopefully it is viewable now. I was just eye balling the fontsize since i dont have the design files and to my judgement .6rem seemed enough, Anywho ive updated the font size. Ive added a main tag to the container as well. could you suggest which tags i can use instead of the p tag? for now <dl> <dd> and <dt> tags seem to fit here. What do you suggest?

  0