Design comparison
SolutionDesign
Solution retrospective
I could think of how to put background image without using html as a container. Then @abraund posted his solution and I took the inspiration from his summary of the solution.
Community feedback
- @rohitd99Posted over 1 year ago
Hi Benevolent
Congrats on completing the challenge.
I'd like to suggest a few changes to your solution,
- For the attribution
footer
would be better suited thanaside
,aside
is generally used for indirectly related content andfooter
is used at the end for information about author, links, contact details etc. - I also find there is no heading in your page, each page should generally contain a
h1
for the title, so I think the name of the person can be ah1
instead ofp
for the title. - The image of the the person is not a decorative image so it should include a
alt
attribute to describe it for assistive technologies or when it fails to load there must be something to describe the image.
Hope it helps
1 - For the attribution
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord