Rohit Deshpande• 870
@rohitd99
Posted
Hi Benevolent
Congrats on completing the challenge.
I'd like to suggest a few changes to your solution,
- For the attribution
footer
would be better suited thanaside
,aside
is generally used for indirectly related content andfooter
is used at the end for information about author, links, contact details etc. - I also find there is no heading in your page, each page should generally contain a
h1
for the title, so I think the name of the person can be ah1
instead ofp
for the title. - The image of the the person is not a decorative image so it should include a
alt
attribute to describe it for assistive technologies or when it fails to load there must be something to describe the image.
Hope it helps
1