Skip to content
Submitted over 1 year ago

Profile Card Component with BEM

Benevolent•490
@bene-volent
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I could think of how to put background image without using html as a container. Then @abraund posted his solution and I took the inspiration from his summary of the solution.

Community feedback

  • Rohit Deshpande•870
    @rohitd99Posted over 1 year ago

    Hi Benevolent

    Congrats on completing the challenge.

    I'd like to suggest a few changes to your solution,

    1. For the attribution footer would be better suited than aside, aside is generally used for indirectly related content and footer is used at the end for information about author, links, contact details etc.
    2. I also find there is no heading in your page, each page should generally contain a h1 for the title, so I think the name of the person can be a h1 instead of p for the title.
    3. The image of the the person is not a decorative image so it should include a alt attribute to describe it for assistive technologies or when it fails to load there must be something to describe the image.

    Hope it helps

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord