profile card component

Community feedback

• 

  Jimmy Hoang•570

  @JimmyHoang296Posted about 3 years ago

  thank you so much for your advice. I still learn to use github properly and your pull is mean so much.

  0
• 

  Yazdun•1,310

  @YazdunPosted about 3 years ago

  Hello 👋 Here I have some suggestions for you

  • Use width:100% and then give max-width:350px, so when element reaches 350px it will stop growing but under 350px it always takes 100% of available width which will make your element looks better on smaller screen and in this specific solution, it makes media query completely unnecessary !

  • Give font-family and background color to body tag.

  • It's better to use rem or em instead of px for fonts.

  • Approach mobile first, It will make your life easier on more complex designs.

  • Put your html content inside a single main tag for each page, It will fix your ACCESSIBILITY issues. each html page should have one main and one level one heading

  • for your background issue I used two separate position:absolute image tags and styled it in your css

  ✅ Also I opened a pull request to your github repository which will fix your background issue and some other fixes to your code.

  I Hope this was helpful

  0