Profile Card component using Sass

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Greetings, Cokorda Agung Yudhana! 👋

  Well done on this challenge! 👍 Your solution looks good! 😀

  I was about to suggest trying to use viewport units to position the background images in this challenge, but it looks like you already found that out. 😅

  The only super tiny thing I might suggest is to perhaps use an <article> tag for the card component (since it is a self-contained element) to bump up the semantics of your HTML just a wee bit! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Cokorda Agung Yudhana•120

  @ckrdiPosted over 3 years ago

  @ApplePieGiraffe Thank you for your feedback and suggestion. :)

  0
• 

  Benjo Quilario•1,810

  @benjoquilarioPosted over 3 years ago

  Great work! It looks well and responsive.

  Keep coding 🔥🔥

  1

  ---

  

  Cokorda Agung Yudhana•120

  @ckrdiPosted over 3 years ago

  Thank you for the feedback. After looking at other people's solution, now I know that we could use viewport width and viewport height as background position property so that the svg would look close to the design. Definitely lesson learned.

  0

  

  Benjo Quilario•1,810

  @benjoquilarioPosted over 3 years ago

  @ckrdi, Glad you learned something, too! Keep coding 😉

  0