Profile card component using HTML and CSS

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey! Congratulations on completing this challenge... Here are some suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="container ...">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change <span class="name">Victor Crest</span> to <h1 class="name">Victor Crest</h1> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • Use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

  • I suggest you put the status of the profile card into the list item to add more semantics to your project...

  <ul class="stats">
     <li><span class="stats-num">80K</span>Followers</li>
     <li><span class="stats-num">803K</span>Likes</li>
     <li><span class="stats-num"> 1.4K</span>Photos</li>
  </ul>
  

  Hope this help!... Keep coding👍

  Marked as helpful

  0