Design comparison
SolutionDesign
Solution retrospective
My first project made alone. What's your opinions?
Community feedback
- @sean-b765Posted over 3 years ago
Hey man good design! Noticed some things you might want to look into
- You specify the height of the card, but when you have
height: auto;
you'll notice your card will fit all of its inner content, and when content is added it will expand. This is much preferred over specifying a value in px, and you can use padding to put whitespace between the content and the edge of your card. - Avoid using
top
to move elements upwards. You did this at profile-pic, and I used to do this too. But you could useposition: absolute;
on the img, then usetransform: translateY(-50%);
to place it in the 50% above where it usually would be. Then it's just a matter of horizontally centering the image.
Have a good one :)
Marked as helpful1 - You specify the height of the card, but when you have
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord