Profile card component using Grid and Flex Box

Community feedback

• 

  Hania B.•1,320

  @techantherePosted almost 3 years ago

  Hey, please take care of semantics in code.

  1. There should be at least one level-one heading and that could be the name of the person here.
  2. Never use heading tags, unless they are really required, it doesn't make sense to use headings for the stats count as a heading always requires some context, so you can instead use paragraph and the same styling for the text when you find it bigger than the normal text.
  3. Since you are using a section tag, For accessibility purposes, there should be one heading following the section tag and that is the person's name in this case. aria-labelledby with section and reference to the id of section's heading will make it accessible.
  4. Don't use px units, instead use rem units as rem units automatically scale up and down elements while px should be rarely used. Good luck!

  Marked as helpful

  0

  ---

  

  Alvaro Guedes•60

  @alvin-devPosted almost 3 years ago

  @techanthere thanks for the help, i'll improve my code :)

  1
• 

  oussama ayadi•470

  @ayadi1Posted almost 3 years ago

  great job

  0