Profile Card Component Using CSS Positioning

Community feedback

• 

  Deborah Odion•10

  @Deborah-OdionPosted over 3 years ago

  Hello didyouseekyng,

  I noticed you commented out your footer element, probably because it wasn't positioning rightly. Semantically, the footer element should come outside the body element, except if you just decide to make it another div element. For this scenario, the footer element could still be used alongside the "flex-direction: column" properties.

  Also, the top image for the card, overflows into the profile picture. This could be solved by giving the profile picture a background color of white, so as to override the top card image overflowing into the profile picture.

  0

  ---

  

  Kingsley Agu•285

  @didyouseekyngPosted over 3 years ago

  @Deborah-Odion I had to comment the footer out because it wasn't positioned well, come to think of it, I should really work on my semantics, and I already made the background color white when I went through your code, I was really impressed. So what do you think of the BEM Naming?

  0