Profile card component

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Yuval,

  Great design, you've nailed this challenge!

  I'd encourage you to swap your <h2> for a <h1> to clear down your accessibility report and use an external style sheet.

  This is a fantastic course if you want to master SCSS.

  Happy coding!

  Marked as helpful

  1
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @hoomi88 ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • Please try BEM for naming element classes. It will help you a lot on bigger projects.

  https://www.frontendmentor.io/solutions/profile-card-solution-m-cH4D2Lp

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  1

  ---

  

  Yuval Carmel•80

  @hoomi88Posted almost 3 years ago

  @tymren608 Thank you so much! Good point.

  I saw your work and I need to start using SCSS, which is cleaner and much more intelligible styling than CSS.

  0