Profile card component!

Community feedback

• 

  President Tree•360

  @PresidentTreePosted about 3 years ago

  Good job on your submission! Here is some feedback...

  HTML

  • Your links in your headings are usually on one line (with the exception of overflow) to save space.
  • The spaces at the end of tags are not needed.
  • The span on line 40 does not need to be within the h5 tag.
  • The numbers should have some tag around them like p.

  CSS

  • Change the position of the background images to background-position: right 50vw bottom 40vh, left 50vw top 40vh;.
  • The corners of the profile card image are poking out. Either change the background-radius of the image or add an overflow: hidden;.
  • Did you mean to leave out screen responsiveness? I don't see any @media.

  Marked as helpful

  0