Design comparison
Solution retrospective
Hey guys, this is Profile Card Component project and i would like feedbacks about the code to contribute with next projects. Thank you.
Community feedback
- @Kamasah-DicksonPosted over 2 years ago
Your solution looks great. good job 👍 But try learning about responsive design Good job keep coding👍
Marked as helpful0@Lara123-pgPosted over 2 years ago@Kamasah-Dickson Thank you! Do you have any content about responsive design?
0@Kamasah-DicksonPosted over 2 years ago@Lara123-pg you can master CSS grid and flex box
Marked as helpful0 - @MarcusTuliusCiceronPosted over 2 years ago
Hey, I'm beginer as well so I don't have alot to say, your solution looks great, one things you can do to fix some accesibility issue reported is change your container div to a main with class container. Your code looks verry organized even it is a small project that's good. May I asked if you did anything special to be able to publish from github pages keeping your folder organization ? When I try to do it without putting everything in root folder it can't find files and image in the folders... that's really annoy me to not be able to keep everything organized
Marked as helpful0@Lara123-pgPosted over 2 years ago@MarcusTuliusCiceron Thanks! Regarding what you asked, how do you normally organize your folders? That I can help, because I already had the same problem.
1@MarcusTuliusCiceronPosted over 2 years ago@Lara123-pg I found help on slack help channel, my mistake was putting " on each url. That was not causing any issue on local serv but once deployed on github pages, it got lost, but now it works fine ^_^
Marked as helpful0@Lara123-pgPosted over 2 years ago@MarcusTuliusCiceron ahh ok, very good, if you need for help, you can tell me.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord