Design comparison
Solution retrospective
-
Argh, the background svg is killing me and I still don't think this was the best solution - any input on how this should have been set is much appreciated... :)
-
positioning in the profile card based on padding - is there a better way to do this? I feel like I'm missing something (and this would not be very efficient if something needs to be modified later).
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Greetings, Ash! π
Good work on this challenge! π The card component looks great! π
I think the way you added and positioned the background images works well for this challenge (it's pretty much the same way I did things in my solution to this challenge).
Using padding to add space around elements isn't a bad idea, either. The only suggestion I have is to use less
px
in your code and moreem
orrem
. I think itβs better to useem
orrem
for as many values of that sort as you can, because then the UI of most of of your app will scale accordingly when thefont-size
changes. If you end up setting some values for margin/padding/etc. inpx
and others inem
orrem
, the layout of your UI might look a little weird when the font-size changes because only the values set inem
and/orrem
got adjusted with the font-size (not those set in px). πHope that is a little helpful. π
Keep coding (and happy coding, too)! π
Marked as helpful1@nyxravenPosted over 3 years ago@ApplePieGiraffe Hello! And thank you for the advice! π Will keep this in mind. Wow, your solution looks perfect!
1@ApplePieGiraffePosted over 3 years ago@nyxraven
Thanks! π Glad to help! π
0 - @Rasoir-genereuxPosted over 3 years ago
Hello, To center the profil card I defined a specific height to my container with display: flex; flex-direction: ...; justify-content: center; align-items: center;
I hope it will help you I learned some stuff in your code too. Thank you :)
ras-gen
1@nyxravenPosted over 3 years ago@Rasoir-genereux Thank you! π It does - feels like I'm abusing too much the padding...
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord