Skip to content
Submitted over 3 years ago

Profile Card Component Solution

Abdulrhman Kotb•395
@abdo-kotb
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Feel free to provide feedback. I will be very happy if you tell me how I can improve.

Community feedback

  • Jeffrey Izelaar•110
    @AstrobeanPosted over 3 years ago

    I see that you're playing around with animations, which is great, because fun is a good motivational tool for studying. Here's some suggestions:

    • Center the card vertically, there are plenty of easy ways to do this, but it's more fun if you figure that one out yourself.
    • Normalize css is cool, but overkill for a tiny project like this.
    • You're using many media queries for the background alone. This pattern usually indicates that you need to stop using absolute units (px) and lean towards relative units and percentages instead. I'm sure you could build a smoother result if you used less media queries, and more appropriate units.

    Happy coding ✌

    Marked as helpful
    2
    Abdulrhman Kotb•395
    @abdo-kotbPosted over 3 years ago

    @Astrobean

    Regarding the centering issue, the reason for that was that I forgot to add <!DOCTYPE HTML> at the beginning of the HTML file. So, when I added it, I had to change and add some CSS properties. I think it looks good now. Not the best experience, but it was a good lesson. 😢 😂

    Thanks a lot for your other suggestions, they are really helpful. I will start searching about them and try to apply them to the design.

    Thanks again for your feedback! And sorry for my bad English.

    0
    Jeffrey Izelaar•110
    @AstrobeanPosted over 3 years ago

    @abdo-kotb No problem. Here's a bonus idea, since you mentioned <!DOCTYPE HTML>: Check out Emmet. You won't regret it.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord