Profile card component solution

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello, Kristijan Krešić! 👋

  Nice job on this challenge! 👏 The card component looks good and the background shapes are rather well placed (something that can be a bit tricky in this challenge)! 😀

  I suggest considering using CSS background images to add and position the background images in this challenge. It'll keep those images out of your HTML, which will make your markup slightly cleaner, and I think it's easier to manage the images and CSS background images, then (since you won't have to worry about things like the images overflowing their container). You could try to use viewport units to position the background images in this challenge, then, (which will allow you to make it so that they do not move around so much when the size of the screen changes (and you won't have to use a media query to adjust the position of the background images on certain screen sizes, then). 😀

  Also, I think you can use an <article> tag for the card component (since it is a self-contained element that makes sense without additional context from a parent element) to make your HTML a little more semantic (which is good for things like accessibility and SEO).

  Hope that helps. 😉

  Keep coding (and happy coding, too)! 😁

  2
• 

  William Spanfelner•155

  @Will-1-AmPosted over 3 years ago

  Have a look also at the font color of the stats text (ie Followers, Likes and photos). That should be an easy improvement. ;)

  0