Design comparison
Solution retrospective
Unfortunately, the bubbles in the background caused side scrolling in smaller screen sizes, and I didn't know how to fix them, so I set them to 'display: none'. If you have a solution to that problem, please write a comment below <3.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Every site/component should always have ✅ a
main
element not only for semantic purposes but also help assistive technology find the main content of your content. For this challenge, it will serve as your components container ⚠️.
More Info: 📚
- The background images should be applied using CSS not HTML ❌. You can accomplish this by using the
background-image
property.
More Info:📚
- The only heading ⚠️ in this challenge is “Victor Crest”. Everything else should be wrapped in a
paragraph
element.
- The statistics are a list ⚠️. They need be created using the Unordered List along with the List Element.
More Info:📚
MDN <ul>: The Unordered List element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
1@AhmedAlhareesPosted almost 2 years ago@vcarames Thank you so much for your response, I will look into it in future projects. <3
0 - Every site/component should always have ✅ a
- @nelsonleonePosted almost 2 years ago
HELLO.....congrats on completing this challenge 🎉 🎉 🎉 Here's now you can fix that , hope it was helpful
Did you build for mobile first? This is because you set a width on it , for the mobile use a max-width, and avoid using height,
Use paddings and margins scale your work,
set height only if need be
HAVE FUN CODING 🎉 🎉
1@AhmedAlhareesPosted almost 2 years ago@nelsonleone Thank you so much for the response. I will consider it in the future <3.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord