Design comparison
SolutionDesign
Solution retrospective
i know iam not good enough , but iam just trying to be better day after day , feel free to post ur opinion even it's negative i won't be sad. :)
Community feedback
- @SinisaVukmirovicPosted almost 2 years ago
Hello!
Looks good for a beginner! Good folder structure, using some semantic elements, but try to use more/all of them.
I would change font import, though. It is a good practice to import fonts in the CSS file, not html. You are using them and setting font-family in the CSS, right? Makes sense to import it there, too.
To further improve, take a look at "mobile first approach".
Hope this was helpful. Best of luck in the future.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord