Design comparison
Solution retrospective
This is my humble solution Not pixel-perfect
If anyone has suggestions on how i can improve my code, please let me know, thank you!
Community feedback
- @jschuh23Posted over 2 years ago
Great solution @Abdelghafour122! I wouldn't worry too much about pixel perfect as that can be very hard to obtain :)
It looks like you have some HTML issues per the Frontend Mentor report. One suggestion I would have is to decrease the number of
section
elements that you're using. Many of these can be changed to adiv
and that's ok. I might just have onesection
element that contains the entire card component.The MDN website has some great info on the
section
element. Specifically: If you are only using the element as a styling wrapper, use adiv
. An unwritten rule is that asection
should logically appear in the outline of a document.Hope that helps!!
1@Abdelghafour122Posted over 2 years ago@jschuh23 thanks janelle ! I really appreciate it !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord