Design comparison
SolutionDesign
Solution retrospective
I still did not get how to place the two images, one at the top left and the other at the bottom right of the body.
Community feedback
- @rsrclabPosted almost 3 years ago
Hi, @BilalMr! Congratulations on your great work ~ I have studied your work, and learned a lot from this one. Here are some opinions that I think about your work.
- I totally agree we can use divs for background circle images, but why don't you try to use pseudo elements like ::before and ::after? I think that could lead to smarter way.
- About card elements, I think card-header, card-body, card-footer classes could be more appropriate than current ones. Top and bottom are usually used on css styles, not on html elements.
- Try to use BEM class naming. http://getbem.com/naming/
- On the view of responsive side, lower than 475px background image looks odd.
Happy coding ~
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord