Profile card component main

Community feedback

• 

  hardy•3,660

  @hardy333Posted about 3 years ago

  Hi, nice solution, good job.

  Few suggestions for your html.

  • Don't use h1 tag for name, h1 is for very important heading not for names in card and stuff like that. You can use h3,h4.. or even p tags and style them accordingly. The fact that text is bold and have little big font doesn't necessary mean that that is h1 element..

  • For stats use ul instead of div, that is a list of stats and it will be semantically correct if you will yous <ul></ul> and <li></li> tags ...

  Marked as helpful

  3
• 

  CliFox•15

  @Ayan-webPosted about 3 years ago

  You did great, your CSS was also very clean as you have use relative unit, one question, how did you make that line ??

  1

  ---

  

  Jakub•210

  @flexer89Posted about 3 years ago

  @Ayan-web Which line do you mean? That grey one?

  0

  

  CliFox•15

  @Ayan-webPosted about 3 years ago

  @flexer89 Yes, that one, sorry for leaving you hanging .

  0

  

  Jakub•210

  @flexer89Posted about 3 years ago

  @Ayan-web it's just border-top

  1