Profile card component main - html css

Community feedback

• 

  Omar Mohy•670

  @omarmohy98Posted almost 3 years ago

  Hi@jussi777, wonderfully done! The code is remarkably responsive. Below is my feedback on potential improvements!

  1.) Instead of <div class="profile"> , let's replace that with <main> element. Doing so will give your code more semantic meaning, will allow screen readers to know this is your main content and Fix the issues appear in Accessibility Report.

  2.) All of your images should have alt attribute with content within the quotations, so in your <img src="images/image-victor.jpg" alt="" /> tag alt attribute may should have the value "victor picture".

  3.) I recommend that you may have to replace your victor name <p> tag into <h1> tag, so your <p>Victor Crest <span>26</span></p> will be <h1>Victor Crest <span>26</span></h1>, that will help to solve the accessibility issues in your report.

  4.) I recommend that you may have to replace your stats <p> tags into <h2> tags for example <p>80K</p> will be <h2>80K</h2>, that will help to solve the accessibility issues in your report.

  If you found my feedback helpful, please mark this comment as helpful. Wonderfully done. Happy coding!

  Marked as helpful

  0

  ---

  

  Anna•110

  @jussi777Posted almost 3 years ago

  Hi @omarmohy22! Thank you for your feedback. I'll improve my code. Happy coding!

  0

  

  Omar Mohy•670

  @omarmohy98Posted almost 3 years ago

  @jussi777 happy to help.

  0