Skip to content
Submitted about 3 years ago

Profile card component made with basic HTML and CSS knowledge

Haico Paulussen•170
@Haico-Paulussen
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Mark Teekman•365
    @markteekmanPosted about 3 years ago

    Hey Haico, nice first solution, looks great 👍🏼

    Some suggestions on how to improve your code:

    • You could try using a <footer> landmark instead of a div with a class of footer for better markup
    • Also wrap your card in a <main> tag for a better and more accessible markup (these first two points should tackle most of your accessibility warnings)
    • You could set the background on the <body> instead of using a separate div to clean up the code a bit

    Keep up the good work!

    Marked as helpful
    1
    Haico Paulussen•170
    @Haico-PaulussenPosted about 3 years ago

    @markteekman Thanks for the feedback Mark!

    I improved my code with your suggestions. It's a lot better now!

    1
    Mark Teekman•365
    @markteekmanPosted about 3 years ago

    @Haico-Paulussen looks really nice! 😃

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord