Profile Card Component (HTTP + CSS)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Luis! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Good effort on this challenge! 👍

  I suggest using CSS background images to add and position the background images in this challenge. It'll keep those images out of your HTML, which will make your markup a little cleaner, and I think it's a little easier to manage the background images, then. BTW, if you use viewport units (such as vw and vh) to position the background images, they won't move around so much when the screen is resized.

  As for height values, I usually like to have things sized by their content whenever I can (because setting explicit values for properties like width and height can lead to too-much-space/overflow issues sometimes). In some cases, this isn't possible, however, so you might have to set a specific width/height for something and take into account the responsiveness of your website and that element. 😉

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  Luis•270

  @luibernipPosted over 3 years ago

  Hello @ApplePieGiraffe, thank you for taking the time looking at my code. Hope you didn't go blind with it. I tried the circles as background images but couldn't place them correctly, but I will keep working on background skills. Using viewport units is a great tip! :) Regarding height values, I see it would be a good technique to define the parent element and then use % or em's for the child.

  Once again, thank you very much for taking the time of reviewing my code.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @luibernip

  No problem! Have a nice day! 👍

  0