Profile card component

Community feedback

• 

  T

  Grace•31,250

  @grace-snowPosted over 3 years ago

  This looks pretty good, well done!

  There are some issues with scroll on mobile, but that will be hard to address without changing HTML structure and how you're adding the background circles.

  Other changes I suggest are only small things :)

  • Alt text should be left intentionally empty on decorative images like the circles and top bit of the card
  • Numbers like 80K don't make sense as headings. They should be in the same paragraph or list item as the word after them. You can wrap in a span to control styling if needed.
  • I wouldn't have the card as main on this. If used in a webpage, there would likely be other content. Similarly, I wouldn't put the stats in a footer element.

  I hope this helps you, good luck

  1
• 

  Pol Thomas•70

  @PolThmPosted over 3 years ago

  Hey thank you very much for your comment. You are totaly right ! Changes done, you can view the code if you are curious.

  0