Design comparison
SolutionDesign
Solution retrospective
Challenge completed with lots of love and bits of google search. I would appreciate any feedback to improve my code and correct inconsistencies. All suggestions welcomed.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The
<figure>
tag should be used only when captions are required with<figcaption>
. In this challenge, it is not required.
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
- Use
margin: 0.938rem
ormargin: 15px
in the.grid
selector so that it has some space when viewed on mobile devices.
I hope you find it useful! ๐
Happy coding!
Marked as helpful1@rayaattaPosted 11 months agoThanks, actually it already has space in mobile view because I centered it and used
min(90%,21rem)
which means it will chose the smallest width on mobile devices because that90%
is smaller than21rem
on mobile devices.And again thanks a lot@MelvinAguilar1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord