Profile Card Component | Desktop Version | Rookie build...

Community feedback

• 

  Akshay•810

  @akshaywebsterPosted almost 3 years ago

  Hi, Naveen!

  Great work with the project.

  To get rid of the Accessibility issues:

  • Make sure you have one h1 tag in your HTML document.

  • Your HTML document should have one main landmark. You can achieve this either by using semantic HTML tags or by declaring your main div with role="main".

  It's always a great idea to learn about HTML5 semantic tags to reduce errors like this as well as to make your site more readable by screen readers.

  Here's a great video on that: HTML5 Semantics

  • Coming to your CSS, you're using a lot of px values, it's always great to use relative units such as em, rem and viewport units such as vh, vw.

  Here's an article by MDN: CSS Values & Units

  I hope my feedback is helpful to you. Have a great day, Naveen! :)

  Marked as helpful

  1
• 

  Hania B.•1,320

  @techantherePosted almost 3 years ago

  The solution looks great, welldone! Just always consider adding h1 first before any other heading. likewise, you should replace h3 with h1 here. Check the accessibility report and add semantic tags it's a good coding habit :)

  Marked as helpful

  1