Profile Card Component designed by using flexbox and grid
Design comparison
Solution retrospective
I struggled with placing profile pic right between two sections. I'm still not sure if it's the right way or not as in responsiveness. If I could get feedback about this, I'll be so happy!
Also any other feedbacks are welcome and I definitely will consider all of them. Thank you.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello birkaany, Congratulations on completing this challenge!
You’ve done really good work here putting everything together, I’ve some suggestions to improve the design:
Its not so good that you used
overflow: hidden
for the whole content, in this case this property is making the content get cropped when the component gets tiny. Instead of usingoverflow
to make the rounded borders useborder-radius
for each card.✌️ I hope this helps you and happy coding!
Marked as helpful0@birkaanyPosted about 2 years ago@correlucas Actually I thought the otherwise is better, keeping control on one element but I didn't realize this bug. Thank you.
I also have another question if you have time; I couldn't stick profile pic right under the pattern, its position changes on responsive behaviour. Could.you give me an idea how to fix it?
1@correlucasPosted about 2 years ago@birkaany I don't get your question, can u explain me please? I saw that the image is placed using
position absolute
and transform, the quickest way to position the image is by using a negative margin likemargin-top: -50px
.0@birkaanyPosted about 2 years ago@correlucas To be more specific; if you test it under 300px wide, the profile pic stays in same position and same size yet the background (pattern) begin shrinking to the top. Is this normal or could it be better?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord