Profile card component, css flexbox

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @BasemAmr ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Especially I like background usage on this project. That was one of main challenges here.

  Here are some of the tips I like to provide.

  1. Card width is too big here. I think using max-width can solve issue.
  2. Please try BEM structure, so that it can help you a lot.

  https://www.frontendmentor.io/solutions/profile-card-solution-m-cH4D2Lp

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  1

  ---

  

  BasemAmr•120

  @BasemAmrPosted almost 3 years ago

  Hello, @tymren608,

  thank you for the congrats and the feedback, I saw your solution, but I didn't understand your using of max-width: 350px; immediately after setting width: 100%;

  isn't it the same as if you write width: 350px; only?

  I searched about the BEM and it seems to be the solution for my problem in naming classes, thank you.

  By the way, is it allowed to remove "attributions" section?

  Best of luck, happy coding

  0