Design comparison
Solution retrospective
Hello community, solution for this challenge, Is There something to improve? let me know please
Community feedback
- @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should also take notes of the following…
- Clean the whitespaces in the code
- Remove unnecessary code to keep it clean
- Include description with the
alt
in image tags. Like this line<img src="./images/image-victor.jpg" alt="">
- Adjust the border size into
border-top: 0.01rem solid var(--dark-gray);
inhr
rule set
Above all, The design looks good. Keep it up! Hope this is helpful!
Marked as helpful1 - @NaveenGumastePosted over 2 years ago
Hay ! Rony Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body
<main class="container"></main>
-> you can't use same
id
more then once, in that case useclass
,-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord