Profile card component challenge hub

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Brobit 👋🏻

  I have some feedback to help you fix the accessibly and HTML issues.

  • In your markup, <section class="card-container">...</section> should be <main class="card-container">...</main> and <section class="background">...</section> should be <div class="attribution">...</div>. Why I suggest <div> Instead of <section>? Well there are a couple of reasons. First, when you use a <section> you have to have a heading, like h1-h6. Next, <section> is for bigger parts of layout, such as, contact us about us, image gallery, etc.
  • Next, I suggest replacing <div class="attribution">...</div> with <footer class="attribution">...</footer>. Also, it should be at the bottom of the page, since that's where the footers usually go. These will fix the accessibility and HTML issues. Don't forget to generate a new repot once you fix the issues.

  I hope this was helpful 👨🏻‍💻 Overall, you've got some great progress here, keep it up. Cheers 👾

  Marked as helpful

  2

  ---

  

  Brobit•60

  @BrobitPosted about 3 years ago

  @kens-visuals ok, thanks for thé return ,i think before doing an another project in must document me about HTML5 tag and how to organise it . thanks for taking your time to write comment about my work and thanks for your constructive comment 🙂👍

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @Brobit no problem, glad I could be helpful 😇

  1