Profile card component | Built with React and styled-components

Community feedback

• 

  Arturo Simon•1,785

  @artimysPosted about 4 years ago

  Hi Conner, you pretty much nailed the matching to the design. Especially with those background images.

  The only minor thing I would suggest is for the bottom background image to stick to the right edge of the viewport.

  Awesome job!! 👍

  2

  ---

  

  Connor Z•5,115

  @zuolizhuPosted about 4 years ago

  @artimys Thanks for your suggestion 😆!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Connor Z! 👋

  I'm so happy to see you submit another challenge! Your solutions always inspire me! 😊

  This one's another pixel-perfect solution that looks great! 👏

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  @ApplePieGiraffe

  BTW, I just recently submitted a solution to the Room Homepage challenge in which (inspired by your solution to the same challenge) I did the exact same thing you did and added the same intro animation using GSAP and stolen (I, I mean, learned) from Dev Ed! 😆

  1

  

  Connor Z•5,115

  @zuolizhuPosted about 4 years ago

  @ApplePieGiraffe The transition of the carousels are amazing 🥳! I will steal your idea for my next carousels project 😆 hahaha!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  @zuolizhu

  😂

  0
• 

  Anna Leigh•5,135

  @brasspetalsPosted about 4 years ago

  Hi, Connor! Overall, the solution looks great!

  I'll preface this by saying I know nothing about React, but I noticed at 479px~480px the card shifts vertically on both Chrome and Firefox. I'm not sure what's causing it, but thought you might like to know. Otherwise, no other issues that I can see!

  1

  ---

  

  Connor Z•5,115

  @zuolizhuPosted about 4 years ago

  Hi @brasspetals ,

  That's a nice catch up on the little detail 👏! But don't worry, its just because I set a break point where the padding top changed from 147px to 173px 🤣 (for presenting purpose, make it looks like same as the design file).

  React is over complicated for this kind of project, but it is worth to try out on some large size project, I will make one in my coming project solution 😎

  Happy coding 🙌!

  1

  

  Anna Leigh•5,135

  @brasspetalsPosted about 4 years ago

  @zuolizhu Welp, I'm half an idiot - can't believe I missed the blatantly obvious. 🤦‍♀️ 😅 This is why I should really stick to my typical rule of not commenting on challenges I haven't completed myself, and also not commenting so late at night! Apologies!

  1

  

  Connor Z•5,115

  @zuolizhuPosted about 4 years ago

  @brasspetals LOL it's okay 😝! I appreciate you looked into my work and make any of the suggestions, that makes me motivated and keep improving 😆!

  1