Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

profile-card-component page

Hirak 160

@hkalita20

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedbacks are wellcome..........

Community feedback

Eugenia 950

@JaneMoroz

Posted

Hi, Hirak! Your solution is great! ❤️

The only thing I've noticed:

  • You need to wrap the main content of the page into the <main> tag. It will solve all these landmark issues and improve accessibility.

Keep it up! And good luck 🍀

Marked as helpful

0
Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="contain"> with the main tag, <h3> with <h1>, <h4> with <p> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

Hope am helpful. HAPPY CODING

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord