Design comparison
Solution retrospective
Still facing issues with centering ☹️. Open to suggestions that can improve my design😊😊
Community feedback
- @adityas24Posted almost 2 years ago
Hi Saswat, great effort by you!
I saw that for displaying the person's image, you are using background image. But the image tag is the most appropriate way to display image here. For more information read this stackoverflow answer on background image vs img tag
Hope it was helpful, Happy coding!
Marked as helpful1@saswat10Posted almost 2 years agoThanks, the article was helpful. I'll make the necessary changes and post a new solution
0 - @Nadine-GreenPosted almost 2 years ago
HEY SASWAT!
About your issue with centering, a quick fix for this would be the give the body a height of 100vh
height:100vh
then a display of griddisplay:grid
and then using the codeplace-items:center
IF THIS WAS HELPFUL IN ANYWAY, DON'T HESITATE TO MARK IT AS HELPFUL :)
HAPPY CODING!
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- “Victor Crest” is a heading. So it needs to be wrapped in a Heading Element.
- The statistics are a list. They need be created using the Unordered List along with the List Element.
More Info:📚
MDN <ul>: The Unordered List element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
1 - To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord