Profile card component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Soytto, congratulations for your new solution!

  👨‍💻 Here’s some tips to improve your solution code:

  1.The approach you've used to center this card vertically is not the best way, because using margins you don't have much control over the component when it scales. My suggestion is that you do this alignment with flexbox using the body as a reference for the container.

  The first thing you need to do is to remove the margins used to align it, then apply min-height: 100vh to the body to make the child (the card/container) align to its size that now will be displaying 100% of the viewport height and then give its alignment with display: flex and align-items: center / justify-items: center.

  2.When the card gets stretched the stats section gets a little bit too near and not fitting good together, something you can do to improve the card responsiveness is create a media query for the stats section and make each stat number stay in a different row after max-width: 350px using a media query, here's the code for that:

  @media (max-width: 350px) {
  footer {
      display: flex;
      flex-direction: column;
  }
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Soytto•180

  @SoyttoPosted about 2 years ago

  @correlucas hey ! Thanks for your message !

  To be honest, I don't understand the 1st part very well... I already use "display: flex and align-items: center / justify-items: center", with a "min-height: 100vh" I used margin in the footer part because "space-between" didn't take all space :/

  However I didn't think about the responsiveness, I just change that, thank you so much !!

  1