Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BG iMAGE 📸:
- Sure I'm here to help you. And let me explain how you can easily apply the
background color
with thesvg
they provided.
- Add the following style rule to your css, and then experience the changes
body {
background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
background-position: right 52vw bottom 35vh, left 48vw top 52vh;
background-repeat: no-repeat, no-repeat;
background-color: hsl(185deg, 75%, 39%);
}
- Tip, Don't forget to generate a new screenshot after editing the
css
file
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the element
<div class="attribution">
the with semantic element<footer>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
HEADINGS ⚠️:
- And, this solution has also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0
Isaac Prime• 390
@Isaacayomi
Posted
@0xAbdulKhalid God Bless you sir. I've added the changes, and it worked fine.
I'll upload the new screenshot now
0
Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
@Ademide07 Glad you found it helpful ! 🤠
0