Design comparison
SolutionDesign
Solution retrospective
Your opinion is welcome
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Adekola, Congratulations on completing this challenge... You have some
accessibility issues
that need to fix.Document should have one main landmark
, Contain the component in<main>
.
<main> <div class="card"> //... </div > </main>
All page content should be contained by landmarks
, Contain the attribution in<footer>
.
<footer> <div class="attribution"> //... </div> </footer>
- I suggest you put the status of the profile card in the
list item
to add moresemantics
to your project. like this:
<ul class="stats"> <li><span class="stats-num">80K</span>Followers</li> <li><span class="stats-num">803K</span>Likes</li> <li><span class="stats-num"> 1.4K</span>Photos</li> </ul>
I hope this is useful to you... Keep coding👍
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord