Profile Card component

Community feedback

• 

  P

  Noemi Gali•280

  @NomiDomiPosted almost 3 years ago

  Hey @4gotpwd,

  Really great job with picking your class names. Your html is general and easy to understand.

  For the css part I would encourage you to add not just the colors to your :root selector, but the font family, sizes, paddings, margins etc. Here is a great tutorial that explains why and how.

  I see you used different types of units which is great! If you want a better and smoother responsiveness, try focusing on using other units than pixels for margins, paddings and font sizes. You can see here what the best practices are.

  Overall great job! :) Hope this helps! Keep coding!!

  Marked as helpful

  2

  ---

  

  4gotpwd•40

  @4gotpwdPosted almost 3 years ago

  @NomiDomi thank you for you feedback! will surely check those sources you mentioned!

  0