Profile card component

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Nikola! 👋

  Nice work on this challenge! 👍 Good job on placing the background images in this challenge (since, as MasterDev333 said, doing so can be quite tricky). 👏

  I only suggest perhaps using a heading tag for the name inside the card component to make your HTML a little more semantic. You could even use the <article> tag for the whole component, then, too! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Nikola•120

  @nikola719Posted almost 4 years ago

  Thank your careful attention for my work. Yes, It is a really good recommendation that use the right tag in html and I feel that I am growing by professional front-end dev.

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work @Nikola! You've finished your first challenge. It seems you didn't load the font correctly. In this challenge, positioning background circles are a little tricky, but you did it well. Hope it helps. Happy coding~ :)

  1

  ---

  

  Nikola•120

  @nikola719Posted almost 4 years ago

  Thank for your recommendation. I think I didn't pay attention to detail. Being detailed in HTML/CSS is essential to become a CSS guru. Looking forward to providing good advices in the future.

  1
• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Great work on your first challenge, @Nikola ~

  The only thing I can recommend is to import correct font for bold weight, and to add padding to container, so that it wouldn't get kissed with border under 350px. Others are really great.

  Happy coding ~ ✨

  1

  ---

  

  Nikola•120

  @nikola719Posted almost 4 years ago

  Thanks for your kind recommendation. In fact, I tested it in my local and font was applied exactly. I have to check it and push it again. I will follow your advice to add padding to the container. It is a kind of professional skill that brings to the table, I think.

  1