Design comparison
Solution retrospective
Hi Guys,
Any feedback on how I can improve my CSS would be much appreciated :)
Thanks
Scott
Community feedback
- @klduplessPosted almost 2 years ago
Wow, this looks great!
To match the challenge design better, I would make a few tweaks.
It looks like you are missing the drop shadow on the profile card. It's very subtle in the original design so it can be hard to tell!
.card { .... box-shadow: [put offset, blur radius, and color here] }
I also think the border-radius on the card needs to be a little bit bigger to match the design.
Lastly, replace the h1 on the name & age, and h2 on the followers, likes, and photos numbers with a span or p element for proper semantic HTML - heading tags should be used for denoting structure, rather than resizing text. More on that here.
Marked as helpful1@Scott-321Posted almost 2 years ago@kldupless ,
Thank you so much for the feedback! Some good tips, especially regarding the use of headings.
Scott
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord