Profile card component

Community feedback

• 

  Obaida Shurbaji•250

  @obaidash99Posted over 2 years ago

  Nice work you did here! Congrats.

  There is only the issue of accessibility, the code should contain at least one h1 heading for more semantic HTML. And don't skip the numbering of the heading, that means when you write an h1, you should write an h2 next time you need a smaller heading or something, then you can style them as you want them to be.

  Hope this helps!

  Marked as helpful

  0
• 

  Macdeesh•610

  @macdeeshPosted over 2 years ago

  Hey Obaida, Thank you for your advice, I already saw it in the report as an accessibility issue and to be honest it was intentional to use h2 instead of h1, because normally this card component should exist as a div inside a body of a full web project, and it has no meaning to use a level-one heading in a profile card. Anyway, thank you again, and I hope we keep in touch with constructive feedbacks for our next projects. Happy coding.

  0

  ---

  

  Obaida Shurbaji•250

  @obaidash99Posted over 2 years ago

  @macdeesh Of course, I will be glad to hear your feedback!

  About headings, it is just a matter of how it is supposed to be written I guess, It has something to do with search engines and how it reads your website. I'm not 100% sure about that but you can google it if you are interested, you'll find helpful things I'm sure about that.

  Good Luck.

  0