Profile card component

Community feedback

• 

  Hossam khalaf•230

  @hossam-khalafPosted about 2 years ago

  hello, @rachelktyjohnson

  Great job what you did with the background-position.

  the only note I can give you about it is to use relative units instead of px

  your code is like that : background-position: top -600px left -750px, bottom -600px right -750px;

  you can change it to something like that:

  background-position: left 50vw top 40vh, right 46vw bottom 50vh; and you won't need to add any media-query for the background because the background position is relative now to the viewport width and height

  Have a great day, Happy Coding 😊

  Marked as helpful

  2

  ---

  

  Rachel Johnson•510

  @rachelktyjohnsonPosted about 2 years ago

  @hossam-khalaf Oh my goodness of course! vw/vh makes so much more sense in this context, I was so deep in my own thoughts I missed the obvious. Thanks so much for your response!

  1

  

  Hossam khalaf•230

  @hossam-khalafPosted about 2 years ago

  @rachelktyjohnson You are much welcome

  keep up the great work

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The profile card's background is decorative, it does not add any value. So its Alt Tag should be left blank and have an aria-hidden=“true” to hides them from assistive technology.

  • The only heading in this challenge is “Victor Crest”. Everything else should be wrapped in a Paragraph Element.

  • The statistics are a list. They need be created using the Unordered List along with the List Element.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  1