Profile card component

Community feedback

• 

  ValouZ•245

  @ValouZPosted almost 4 years ago

  Hey,

  For a first shot, that's a really great project.

  • The way i places the bubbles in the background is to use properties top or bottom and left or right but the way you placed them is a good way too. I recommende you to go check those properties maybe it would have help you.

  • Instead of placing a <hr> tag on your bottom card section, you should have done a border-top: 1px solid rgba(150, 150, 150, 0.5); on your div. The result is the same but you use less html and it's easier to place. Not a big thing.

  • I think that the classes followers, likes and photos on your social media section is useless because the three part havev the exact same properties. You used display: grid; to place them bu i think that you could have jump on the display: flex; solution. Everything is done automatically.

  • You can check this site : https://css-tricks.com/snippets/css/a-guide-to-flexbox/ --> trust me on this one

  • And to practice go on this one : http://flexboxfroggy.com/ --> hope you'll enjoy

  If you don't know flexbox, learn them and you will discover a whole new world of hapiness.

  Have a good day and if you want you can go check my version

  3

  ---

  

  em•70

  @emityiskaPosted almost 4 years ago

  @ValouZ Thank you so much for your feedback. I am going to practice with the flexbox website. I am not 100% sure about the concept of the CSS grid system, so this would be perfect for me to play around with. Thank you again for all the input. :)

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work @emityiska. Some suggestions here.

  • I recommend you to use background-image or pseudo-elements for drawing background rather than real doms.
  • Remove border-radius on card-top. You already set border-radius to card. Add overflow: hidden; to card to make rounded border. Hope it helps. Happy coding~ :)

  1

  ---

  

  em•70

  @emityiskaPosted almost 4 years ago

  @MasterDev333 Thank you for your advise. Yes, I realized that a lot of people utilize the pseudo-elements. I need to play around with them more to be more comfortable using them here and there. Thank you :)

  0