Profile Card Component

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi James,

  Decent solution, pretty much spot on.

  This is a good little guide on css units some smaller stuff definitely lends it's self to px like divider, borders, fixed heights/widths for icons. But generally you should steer clear of fixed heights & widths.

  Keep up the momentum Happy coding!

  Marked as helpful

  0
• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Hey @neenreva

  Good job on completing this challenge. I'd say you've done quite a nice job on it!

  Here are a few suggestions based on your final solution:

  • When you're building layouts, you usually don't want to use fixed values for width and height property. Instead, you have to accommodate the layout to the content you have available. Try finding ways to use less of the width and height properties and instead add more spacing with padding and focus on aligning and positioning items using features of CSS such as flexbox or grid

  • Your card as a whole is a bit too small. Maybe make it just a bit bigger

  0