Profile Card Component

Community feedback

• 

  P

  Godwin•410

  @itadori-kunPosted about 2 years ago

  Hello kylejrhoden, I want to congratulate you for the awesome work you have done with the code, great work. Though I do have a few suggestions:

  • Try to write more semantic-UI instead of the use of Divs which are non-semantic to aid accessibility. Check out the link, and learn to know what each tag does https://www.w3schools.com/html/html5_semantic_elements.asp

  • On this line of code <img src="images/bg-pattern-card.svg" id="pattern" aria-hidden="true">, add an alt="" just like this since it is presentational.

  • On this line of code <img src="images/image-victor.jpg " alt="Victor Profile Image">, the alt should not contain any words like pictures, images, and related since it is automatically been read by the screen reader to avoid repetition.

  I hope you find this helpful, 👻 Happy coding.

  0