Design comparison
Solution retrospective
Hello! I have completed this task. Please take a look to my submission and give feedbacks accordingly.
Community feedback
- @Sujood-QureshiPosted almost 2 years ago
Hey Harshit! 🙋♂️
Congratulations on completing the Profile card component challenge
I have some suggestions for you about your code.
Index.html
-
Use <main> tag to wrap the page's main content instead of <div> tag. It will show the search engines that the particular content is essential on that page. You can read more about <main> tag here.
-
You should use the <h1> tag. it is a best practice to ensure that the beginning of a page's main content starts with <h1>tag element, and also to ensure that the page contains only one <h1>tag element
Style.css
- Use relative units like em or rem instead of the fixed unit like px. The relative units can change elements size to the parent container
I hope you find it useful! May your front-end journey be filled with successful 😊😊
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord