Profile Card Component

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  FreeCodeCamp Centering Your Content

  • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • Change width to max-width in your component’s container to make it responsive.

  • The profile card’s background is decorative, it does not add any value. So its Alt Tag should be left blank and have an aria-hidden=“true” to hides them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The figure element is not needed for this challenge as there is no figcation.

  • “Victor Crest” is a heading. So it needs to be wrapped in a Heading Element.

  • The statistics are a list. They need be created using the Unordered List along with the List Element.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1
• 

  Nick•160

  @HarmoniaCodesPosted almost 2 years ago

  Hello! Congrats on completing the challenge! I have one piece of feedback to offer.

  • Your background .svg elements don't resize/aren't responsive to the viewport size. You may want to check out some scaling options such as media queries or using the clamp function. You can find their documentation below.

  Using Media Queries: : https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

  CSS clamp() function : https://developer.mozilla.org/en-US/docs/Web/CSS/clamp

  0
• 

  M.Panda•200

  @SebastienpandaPosted almost 2 years ago

  Hello, congratulations for this project! I don't see much to say, it's mastered! GG

  0