Profile card component

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey thanks a lot for the shout-out 😳 Really happy to hear about inspiring you, it motivates me to go further as well!

  Final result looks awesome! Just couple tips to consider for your future projects:

  • Try to avoid setting max-height or any fixed height for text containing elements, as it can cause various issues, such as content overflow when the data changes or the user changes their settings for the base font-size etc. etc.

  • Avoid using px as much as u can, better option would be to use the responsive em/rem. Here is a great resource on YT for clarifying all the differences between rem/em and explain why to use them: https://www.youtube.com/watch?v=dHbYcAncAgQ

  Hope you find this feedback helpful!

  Marked as helpful

  1

  ---

  

  Codenaud•130

  @codenaudPosted over 1 year ago

  👋 Hi @visualdenniss

  Thank you very much for the recommendation rem I am going to make some changes in the project and I will upload it again applying this option.

  Of course, your feedback is always a great help.

  👾 Thanks

  0
• 

  Amir Hashemi•480

  @AmirhosseinHashemiPosted over 1 year ago

  Hello my friend ...

  • I checked your project and it was great and depends on my little knowledge I written my opinion :

  • you can create a specific css page for write your customized css code and then use it in your project, This way cause you have a clean , readable and comfortable access to your code.

  • It is better to style your elements with class that you define for that not using element name.

  Marked as helpful

  0

  ---

  

  Codenaud•130

  @codenaudPosted over 1 year ago

  👋 **Hi @seyyeddev **

  I appreciate your advice and I have made some modifications to the css code of the project.

  Finally, and although your recommendation is very helpful, I have chosen to eliminate the [d-flex, d-column] classes and try to apply as few classes as possible. Of course, well defined in the style sheet.

  Thank you very much for your feedback, it has been very helpful.

  👾 Thanks

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Codenaud•130

  @codenaudPosted over 1 year ago

  👋 Hi @0xAbdulKhalid

  Thank you very much for your recommendation, you are absolutely right, in HTML5 the structure should be completely semantic and using [div] does not make much sense.

  I am going to make the necessary changes to be able to solve this issue and I will upload the project again.

  Of course, your comments are always very helpful. Thank you for taking the time to review my code.

  👾 Thanks

  0