Profile Card Challenge

Community feedback

• 

  AssadullahADELYAR•200

  @AssadullahADELYARPosted about 1 year ago

  congratulations on completing this challenge 🎉🎉

  This is great but I think you should consider changing some things:

  You don't need to have extra div's to set two background-images on your body Instead you can do something like this:

  inside of your body

  body {
  background-image: url(images/bg-pattern-top.svg);
  background-repeat: no-repeat;
  background-size: cover;
  background-position: top -40rem left -30rem;
  }
  

  ofcourse you can use more than one background image like this:

  body {
  background-image: url(images/bg-pattern-top.svg), url(images/bg-pattern-bottom.svg);
  }
  

  please check This

  I hope it was helpful for you👍👍

  Happy coding 🙂🙂

  Marked as helpful

  1

  ---

  

  alexivany•80

  @alexivanyPosted about 1 year ago

  @AssadullahADELYAR Thank you very much for your feedback! Honestly I wasn't sure the best way to go about creating the background image, and the way you mentioned makes a lot more sense than my convoluted container way lol

  I've updated my code with a much cleaner solution, thank you for your help!

  0

  

  AssadullahADELYAR•200

  @AssadullahADELYARPosted about 1 year ago

  @alexivany I am happy that you find my feedback helpful.

  If you want to practice CSS flexbox, I recommond you to use Flexobx-Froggy it is fun game.

  there are CSS Grid games as well.

  Let me if it was helpful Happy Coding

  1